Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kill: improve kill's description #7007

Merged
merged 4 commits into from
Sep 2, 2021
Merged

kill: improve kill's description #7007

merged 4 commits into from
Sep 2, 2021

Conversation

en-jin19
Copy link
Contributor

@en-jin19 en-jin19 commented Aug 27, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

updated the description about KILL in "sql-statements/sql-statement-kill.md" document.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 27, 2021 15:43
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2021
@en-jin19 en-jin19 requested a review from hawkingrei August 27, 2021 15:45
@en-jin19 en-jin19 added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Aug 27, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Aug 27, 2021
@en-jin19 en-jin19 added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-4.0 type/enhancement The issue or PR belongs to an enhancement. and removed needs-cherry-pick-release-4.0 labels Aug 27, 2021
@TomShawn TomShawn removed the missing-translation-status This PR does not have translation status info. label Aug 30, 2021
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Sep 1, 2021
TomShawn
TomShawn approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2021
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Sep 2, 2021
@hawkingrei
Copy link
Member

LGTM

@ti-chi-bot
Copy link
Member

@hawkingrei: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

TomShawn commented Sep 2, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 2, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Sep 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 445405e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2021
@ti-chi-bot ti-chi-bot merged commit aae6933 into pingcap:master Sep 2, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7065.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7066.

ti-chi-bot added a commit that referenced this pull request Sep 2, 2021
@ti-chi-bot
kill: improve kill's description (#7007) (#7065)
431afd6
ti-chi-bot added a commit that referenced this pull request Sep 2, 2021
@ti-chi-bot
kill: improve kill's description (#7007) (#7066)
3265c75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@en-jin19 @ti-chi-bot @hawkingrei @TomShawn